Blame and remove all peers with KE errors #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When both KE timeout occurred for one peer, and a second peer double spent the unmixed inputs previously shown to the server, only the double spending peer was removed from the mix. Keeping the timed-out client in later runs caused server hangs when attempting to send rerun messages, because the client's out message channel was not being read anymore.
dajohi
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When both KE timeout occurred for one peer, and a second peer double
spent the unmixed inputs previously shown to the server, only the
double spending peer was removed from the mix. Keeping the timed-out
client in later runs caused server hangs when attempting to send rerun
messages, because the client's out message channel was not being read
anymore.