Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move empty pattern check into while loop #81

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

Pheenoh
Copy link
Contributor

@Pheenoh Pheenoh commented Aug 19, 2024

fixes #78

@encounter
Copy link
Member

Thank you!

@encounter encounter merged commit 9386240 into decompals:main Aug 20, 2024
1 check passed
@simonlindholm
Copy link
Contributor

This feels weird to me -- isn't it the same as "if (handle->pattern.empty()) { return false; }"?

@Pheenoh
Copy link
Contributor Author

Pheenoh commented Aug 20, 2024

This feels weird to me -- isn't it the same as "if (handle->pattern.empty()) { return false; }"?

I don't completely understand the context here, but the handle's directory iterator not being iterated through was causing the file not found error in the linked issue due to an early return when there was an empty pattern, so that's why i moved it to the while loop.

Maybe there is a better fix, but I wanted to get something in here as it was breaking multiple projects using wibo with mwcceppc.exe

EDIT: Okay yeah this makes more sense lol

@Pheenoh Pheenoh deleted the fix branch August 20, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MWCC]: mwcceppc file path behavior broken
4 participants