feat(blog): expose unique identifier #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging OptionsShould a new tag be published when this PR is merged?
|
Comment on lines
+14
to
+20
| return (current as Record<string, T>[]).map((item) => { | ||
| const id = (item.name as string).split(path)[1]?.replace("/", ""); | ||
| return { | ||
| ...item[accessor], | ||
| id, | ||
| }; | ||
| }); |
There was a problem hiding this comment.
why add it manually? I think this should be in the table, maybe by a workflow that runs it when this changes comes to production
There was a problem hiding this comment.
why add it manually? I think this should be in the table, maybe by a workflow that runs it when this changes comes to production
@IncognitaDev, by default it already returns, but in a different format.
ex: collections/blog/categories/05430797e2d1 or collections/blog/posts/1d76260ef8a8
the objective is to do the split and return only the unique identifier to use later
There was a problem hiding this comment.
example of how I'm using
matheusgr
approved these changes
Jan 6, 2025
vitoUwu
pushed a commit
that referenced
this pull request
Jan 30, 2025
* feat(blog): expose unique identifier * feat(blog): define id prop to optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this Contribution About?
This PR aims to add the unique id of the blog post.
As the post can be 100% edited (including the slug), we added this id to have a unique identifier.
Aiming at a scenario in which we save comments using the post_slug in the comments table, if there were any changes to the slug due to an error or anything else, we would lose all data registered in the system due to this change.
