Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VTEX] - Fix collection's canonical #425

Merged

Conversation

gabrielMatosBoubee
Copy link
Contributor

@gabrielMatosBoubee gabrielMatosBoubee commented Feb 22, 2024

What is this contribution about?

This is about the canonical (Fix)

Explain the fix motivation

Vtex-Canonical.-.Compressed.with.FlexClip.mp4

Before the fix

image

The fix in action

image

Link to test:

https://www.embelleze.com/promocao-especial-15off

@guitavano guitavano merged commit 9bc0cfd into deco-cx:main Feb 27, 2024
1 check passed
guitavano added a commit that referenced this pull request Feb 29, 2024
* feat: linx integration

* fix: remove duplicated app config

* fix: whoops

* feat: Min threshold (#400)

* refactor: use interfaces intead of types
#397 (comment)

* WAKE - Dados de attributeSelections adicionados no additionalProperty  (#411)

* feat: novos dados inseridos em transform

* feat: atualização nos types e transform

* fix type

---------

Co-authored-by: Caio Nogueira <programmercaio98@gmail.com>
Co-authored-by: Caio Nogueira <81397501+caioprogrammer@users.noreply.github.com>

* Convert to Uintarray (#412)

Signed-off-by: Marcos Candeia <marrcooos@gmail.com>

* allow fetch with cache on linx (#353)

* [Verifed Reviews] - PDP (#416)

* feat: add reviewCount in reviewRating

* chore: add comment

* Update verified-reviews/utils/client.ts

---------

Co-authored-by: Marcos Candeia <marrcooos@gmail.com>

* Add DiscountHighLight items in the teasers (#369)

* feat: Add discount highlight in teasers

* Update vtex/utils/transform.ts

Co-authored-by: Tiago Gimenes <tlgimenes@gmail.com>

---------

Co-authored-by: Luigi <luigidias@protonmail.com>
Co-authored-by: Tiago Gimenes <tlgimenes@gmail.com>

* re-add linx cache disable (#419)

* re-add linx cache disable

* enable linx cache (#420)

* Revert "re-add linx cache disable (#419)"

This reverts commit 9a254c4.

* add comment w/ warning

* Tavano/standardize flags (#401)

* standardize flags

* fmt

* get cookie client side

* fmt

* unused flags

* add try catch

* add try catch

* get cookie name from const

* fmt

* remove local

* Prtemplate (#421)

* create a pull request template

* chage phrase

* Create platform assignment manually set on admin app (#423)

* Add platform assignment for site

Signed-off-by: Marcos Candeia <marrcooos@gmail.com>

* Add default platform as kubernetes when creating site

Signed-off-by: Marcos Candeia <marrcooos@gmail.com>

* Add site name for new domain

Signed-off-by: Marcos Candeia <marrcooos@gmail.com>

* Change default to play

Signed-off-by: Marcos Candeia <marrcooos@gmail.com>

---------

Signed-off-by: Marcos Candeia <marrcooos@gmail.com>

* Add title on platform assignment (#424)

* Add title on platform assignment

Signed-off-by: Marcos Candeia <marrcooos@gmail.com>

* Defaulting to null values

Signed-off-by: Marcos Candeia <marrcooos@gmail.com>

---------

Signed-off-by: Marcos Candeia <marrcooos@gmail.com>

* LiveControls: open cms in new tab (#427)

* open cms in new tab

* works with event.metaKey as well (macos cmd)

* window -> globalThis.window

* check plausible before execute (#428)

* more improvements (#429)

* Reviews and Rating (VTEX) (#430)

* Build

* Feat Reviews And Rating

* Remove Unsuable Things

* Move to Transform

* some improvements

---------

Co-authored-by: guitavano <tavano62@gmail.com>

* fix: canonical (#425)

Co-authored-by: guitavano <tavano62@gmail.com>

* refactor: apply changes from...
... #410 (comment)

* refactor: use Secret, remove hardcoded headers

* perf: Optimize build routes (#432)

Co-authored-by: Luigi <luigidias@protonmail.com>

* Add hash at manual plausible script (#437)

* add hash at plausible manual script

* fmt

* refactor: set secret key on headers

* feat: linx integration

* fix: remove duplicated app config

* fix: whoops

* refactor: use interfaces intead of types
#397 (comment)

* refactor: apply changes from...
... #410 (comment)

* refactor: use Secret, remove hardcoded headers

* refactor: set secret key on headers

---------

Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Co-authored-by: Tiago Gimenes <tlgimenes@gmail.com>
Co-authored-by: guitavano <tavano62@gmail.com>
Co-authored-by: Caio Nogueira <programmercaio98@gmail.com>
Co-authored-by: Caio Nogueira <81397501+caioprogrammer@users.noreply.github.com>
Co-authored-by: Marcos Candeia <marrcooos@gmail.com>
Co-authored-by: Matheus Gaudencio do Rêgo <matheusgr@users.noreply.github.com>
Co-authored-by: Gabriel Matos Boubee <108771428+gabrielMatosBoubee@users.noreply.github.com>
Co-authored-by: Luigi <66072698+lui-dias@users.noreply.github.com>
Co-authored-by: Luigi <luigidias@protonmail.com>
Co-authored-by: Viktor Marinho <56888067+viktormarinho@users.noreply.github.com>
Co-authored-by: Gabriel Kerchner <89463285+gabekerchner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants