Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fcm.gemspec #101

Merged
merged 1 commit into from
Apr 16, 2022
Merged

Update fcm.gemspec #101

merged 1 commit into from
Apr 16, 2022

Conversation

qgzvcyxjfr
Copy link
Contributor

follow up on faraday 2:

quote from the upgrade guide:

That's great! What should I change in my code immediately after upgrading?
If you just use the default net_http adapter, then you don't need to do anything!

update gemspec for faraday 2
@sabman
Copy link
Member

sabman commented Mar 23, 2022

thanks @qgzvcyxjfr The tests seem to pass since we use the default adapter. Can someone else review this as well? @maszuDEV maybe?

@ahteshamtariq
Copy link

@sabman any tentative date or plan to release this?

@sabman
Copy link
Member

sabman commented Apr 1, 2022

@ahteshamtariq I was just waiting for any further feedback. If I don't hear any issues regarding this version I'll cut out a release by Monday. Hope that helps. If you get a chance to try it out please leave any feedback

@ahteshamtariq
Copy link

@sabman I have tested it with faraday 2.2.0 and it's working for me. But I've tried it only for the android platform. Looking forward to having reviews from others also.

@omarluq
Copy link

omarluq commented Apr 14, 2022

@sabman any ideas on when are you planning to release this 😃 ?

@sabman sabman merged commit 76554d5 into decision-labs:master Apr 16, 2022
@sabman sabman mentioned this pull request Apr 16, 2022
@noctivityinc
Copy link

@sabman +1 here. With the release of Heroku's stack-22, we need to use Ruby 3.1, which is incompatible with the version of faraday that FCM requires. If you update the gemspec to use the newer version then we will be all set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants