Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): validate config file version number #413

Merged
merged 2 commits into from
Mar 9, 2021
Merged

fix(cli): validate config file version number #413

merged 2 commits into from
Mar 9, 2021

Conversation

simonas-notcat
Copy link
Contributor

No description provided.

@simonas-notcat simonas-notcat requested a review from mirceanis March 9, 2021 13:32
mirceanis
mirceanis requested changes Mar 9, 2021
View reviewed changes
Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea!
I believe this check is not only specific to server config. It should probably be done in createObjects() or getConfig() directly.
What do you think?

packages/cli/src/server.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 9, 2021 •
edited
Loading

Codecov Report

Merging #413 (f21e8eb) into main (6cc8f92) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #413   +/-   ##
=======================================
  Coverage   67.58%   67.58%           
=======================================
  Files          62       62           
  Lines        1530     1530           
  Branches      247      247           
=======================================
  Hits         1034     1034           
  Misses        400      400           
  Partials       96       96

mirceanis
mirceanis approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@simonas-notcat simonas-notcat merged commit fb5668c into main Mar 9, 2021
@simonas-notcat simonas-notcat deleted the hotfix/check-config-version branch March 9, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirceanis mirceanis mirceanis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonas-notcat @mirceanis