Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUICKFIX: Coordinate Mediation V3 #1297

Merged
merged 9 commits into from
Dec 8, 2023

Conversation

radleylewis
Copy link
Contributor

Coordinate Mediation Enhancements

This PR implements some minor refactoring and best practices with respect to the did-comm protocol (specifically coordinate mediation)

What is being changed

The PR:

  • FIX: correctly exports the coordinate mediation manager v3 from the package (and addresses naming conflicts with v2 exports)
  • ensures consistent naming for differentiation of Version 2 Coordinate Mediation Specification and Version 3
  • introduces better error handling on the mediate cli (directs to setup instructions in mediation agent)
  • updates the mediation-manager README for more descriptive instructions on setup (both programatically and through the agent.yml)
  • adds documentation/notes in code for easier consumption by developers

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because _________, and I am aware that a PR without tests will likely get rejected.

Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mirceanis mirceanis merged commit ea2d99a into decentralized-identity:next Dec 8, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants