-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(did-comm): add support for some of the AES based content and key encryption algorithms #1180
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
19a8229
feat(did-comm): initial support for A256KW key wrapping for didcomm
mirceanis dcc120a
chore(deps): bump dependencies and adapt
mirceanis 336968f
feat(did-comm): support A256GCM content encryption
mirceanis 03ebc9d
chore(deps): use @noble/* libraries instead of elliptic, @stablelib/,…
mirceanis e634240
feat(did-comm): add AES encryption and key wrapping
mirceanis f9ee365
ci: try to parallelize CI steps using caches
mirceanis f34f6ee
fix(deps): bump did-* libraries
mirceanis e71a5a0
fix(data-store): compare decrypted keys when importing
mirceanis 56a9e2f
feat(did-comm): initial support for A256CBC-HS512 content encryption
mirceanis cde9e31
feat(did-comm): add support for A256CBC-HS512 content encryption
mirceanis 777ec8f
chore(deps): bump transmute dependencies
mirceanis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -100,7 +100,7 @@ export default (testContext: { | |
}, | ||
proofFormat: 'jwt', | ||
}) | ||
const verifyResult = await agent.verifyCredential({credential: verifiableCredential}) | ||
const verifyResult = await agent.verifyCredential({ credential: verifiableCredential }) | ||
|
||
expect(verifyResult.verified).toBe(true) | ||
expect(verifiableCredential).toHaveProperty('proof.jwt') | ||
|
@@ -403,7 +403,7 @@ export default (testContext: { | |
hello: 'world', | ||
}, | ||
credentialStatus: { | ||
id: 'override me', | ||
id: 'override:me', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The latest |
||
type: 'ThisMethodDoesNotExist2022', | ||
}, | ||
}, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JWT signing for ES256K now uses canonical signatures, with a low
S
value (through the use of@noble/curves
)This eliminates signature malleability, just like what happens for ethereum signatures, but it also means tests will change.