Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] 1098 build and test issues #1101

Merged
merged 4 commits into from
Jan 20, 2023
Merged

[fix] 1098 build and test issues #1101

merged 4 commits into from
Jan 20, 2023

Conversation

mirceanis
Copy link
Member

@mirceanis mirceanis commented Jan 12, 2023

What issue is this PR fixing

fixes #1098 (partially)

What is being changed

This PR makes a number of changes to the dependency resolution and declares dependencies more strictly in each package.
This changes the package manager to pnpm instead of yarn

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because _________, and I am aware that a PR without tests will likely get rejected.

Details

If applicable, add screen captures, error messages or stack traces to help explain your problem.

@mirceanis mirceanis force-pushed the 1098-build-and-test-issues branch from d4b86f7 to 836f9c3 Compare January 19, 2023 14:48
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #1101 (836f9c3) into next (125bf42) will decrease coverage by 0.15%.
The diff coverage is 78.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1101      +/-   ##
==========================================
- Coverage   80.25%   80.10%   -0.15%     
==========================================
  Files         118      132      +14     
  Lines        4056     4741     +685     
  Branches      875     1060     +185     
==========================================
+ Hits         3255     3798     +543     
- Misses        798      943     +145     
+ Partials        3        0       -3     

Copy link
Contributor

@simonas-notcat simonas-notcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mirceanis mirceanis merged commit b8ba795 into next Jan 20, 2023
@mirceanis mirceanis deleted the 1098-build-and-test-issues branch January 20, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors during tests run
2 participants