fix: IHandleMessage interface

decentralized-identity · Sep 7, 2020 · 0ab68fd · 0ab68fd
1 parent b6d1e36
commit 0ab68fd
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 34 deletions.
diff --git a/packages/daf-core/src/index.ts b/packages/daf-core/src/index.ts
@@ -28,7 +28,7 @@ export {
   IKeyManagerSignEthTXArgs,
   IKeyManagerSignJWTArgs,
 } from './key-manager'
-export { MessageHandler, IHandleMessage } from './message-handler'
+export { MessageHandler, IHandleMessage, IHandleMessageArgs } from './message-handler'
 export { Message } from './message'
 export { AbstractIdentityProvider } from './abstract/abstract-identity-provider'
 export { AbstractKeyManagementSystem } from './abstract/abstract-key-management-system'

diff --git a/packages/daf-core/src/message-handler.ts b/packages/daf-core/src/message-handler.ts
@@ -12,15 +12,14 @@ export const EventTypes = {
   error: 'error',
 }
 
+export interface IHandleMessageArgs {
+  raw: string
+  metaData?: IMetaData[]
+  save?: boolean
+}
+
 export interface IHandleMessage extends IPluginMethodMap {
-  handleMessage: (
-    args: {
-      raw: string
-      metaData?: IMetaData[]
-      save?: boolean
-    },
-    context: IAgentContext<IDataStore>,
-  ) => Promise<Message>
+  handleMessage(args: IHandleMessageArgs, context: IAgentContext<IDataStore>): Promise<Message>
 }
 
 export class MessageHandler extends EventEmitter implements IAgentPlugin {
@@ -48,14 +47,7 @@ export class MessageHandler extends EventEmitter implements IAgentPlugin {
     }
   }
 
-  public async handleMessage(
-    args: {
-      raw: string
-      metaData?: IMetaData[]
-      save?: boolean
-    },
-    context: IAgentContext<IDataStore>,
-  ): Promise<Message> {
+  public async handleMessage(args: IHandleMessageArgs, context: IAgentContext<IDataStore>): Promise<Message> {
     const { raw, metaData, save } = args
     debug('%o', { raw, metaData, save })
     if (!this.messageHandler) {

diff --git a/report/daf-core.api.md b/report/daf-core.api.md
@@ -247,14 +247,17 @@ export class IdentityManager implements IAgentPlugin {
 // @public (undocumented)
 export interface IHandleMessage extends IPluginMethodMap {
   // (undocumented)
-  handleMessage: (
-    args: {
-      raw: string
-      metaData?: IMetaData[]
-      save?: boolean
-    },
-    context: IAgentContext<IDataStore>,
-  ) => Promise<Message>
+  handleMessage(args: IHandleMessageArgs, context: IAgentContext<IDataStore>): Promise<Message>
+}
+
+// @public (undocumented)
+export interface IHandleMessageArgs {
+  // (undocumented)
+  metaData?: IMetaData[]
+  // (undocumented)
+  raw: string
+  // (undocumented)
+  save?: boolean
 }
 
 // @public (undocumented)
@@ -617,14 +620,7 @@ export class Message implements IMessage {
 export class MessageHandler extends EventEmitter implements IAgentPlugin {
   constructor(options: { messageHandlers: AbstractMessageHandler[] })
   // (undocumented)
-  handleMessage(
-    args: {
-      raw: string
-      metaData?: IMetaData[]
-      save?: boolean
-    },
-    context: IAgentContext<IDataStore>,
-  ): Promise<Message>
+  handleMessage(args: IHandleMessageArgs, context: IAgentContext<IDataStore>): Promise<Message>
   // (undocumented)
   readonly methods: IHandleMessage
 }

diff --git a/scripts/generate-schemas.ts b/scripts/generate-schemas.ts
@@ -14,7 +14,7 @@ import {
 const apiExtractorConfig = require('../api-extractor-base.json')
 
 const agentPlugins: Record<string, Array<string>> = {
-  'daf-core': ['IResolveDid', 'IDataStore', 'IKeyManager', 'IIdentityManager'],
+  'daf-core': ['IResolveDid', 'IDataStore', 'IKeyManager', 'IIdentityManager', 'IHandleMessage'],
   'daf-w3c': ['IW3c'],
 }