Use https:// references in JSON schemas
#451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonio-ivanovski
requested review from
rado0x54,
csuwildcat,
kimdhamilton and
brentzundel
as code owners
kimdhamilton
approved these changes
Nov 4, 2023
rado0x54
reviewed
Feb 8, 2024
| @@ -2,7 +2,7 @@ const Ajv = require('ajv'); | |||
| const addFormats = require('ajv-formats'); | |||
|
|
|||
| const schemas = { | |||
| "http://identity.foundation/claim-format-registry/schemas/presentation-definition-claim-format-designations.json": { | |||
| "https://identity.foundation/claim-format-registry/schemas/presentation-definition-claim-format-designations.json": { | |||
| "$schema": "http://json-schema.org/draft-07/schema#", | |||
There was a problem hiding this comment.
Thanks for this PR we will merge it as is, but will fork of another PR that generally looks at all the occurrences of http vs https. (like the one here)
There was a problem hiding this comment.
@kimdhamilton Seems like all the http://identity.foundation (apart from in package.json) where addressed in this PR. So not sure about this comment anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the other DIF schemas are using
https://references to other schemas, not sure why the case is here thathttp://was used, but I think that should be changed. This is because validators can consider these two different schemas causing potentially two downloads and two compilings of the schemas. For us as we plan on having the schemas locally (not downloadable), we either have to have two entries or make local workaround (that replaces the http with https).This PR is fixing this issue for this package schemas.