Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support deployment of ens names #213

Merged
merged 9 commits into from
Sep 18, 2023
Merged

feat: support deployment of ens names #213

merged 9 commits into from
Sep 18, 2023

Conversation

marianogoldman
Copy link
Contributor

No description provided.

@marianogoldman marianogoldman marked this pull request as ready for review September 18, 2023 12:29
@@ -15,6 +15,7 @@ HTTP_SERVER_HOST=0.0.0.0

RPC_URL=https://rpc.decentraland.org/mainnet?project=worlds-content-server
MARKETPLACE_SUBGRAPH_URL=https://api.thegraph.com/subgraphs/name/decentraland/marketplace
#ENS_SUBGRAPH_URL=https://api.thegraph.com/subgraphs/name/ensdomains/ens
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is ok for this to be commented?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for now. So we don't have this enabled by default. If no var, no ens enabled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any case, we manage this via definitions.

@marianogoldman marianogoldman merged commit e4dfa56 into main Sep 18, 2023
@marianogoldman marianogoldman deleted the ens-names branch September 18, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants