fix: send builder url as part of notification metadata

decentraland · May 20, 2024 · 4f7daea · 4f7daea
1 parent c3d358e
commit 4f7daea
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/src/controllers/handlers/permissions-handlers.ts b/src/controllers/handlers/permissions-handlers.ts
@@ -144,12 +144,13 @@ export async function postPermissionsHandler(
 
 export async function putPermissionsAddressHandler(
   ctx: HandlerContextWithPath<
-    'namePermissionChecker' | 'permissionsManager' | 'worldsManager' | 'notificationService',
+    'config' | 'namePermissionChecker' | 'permissionsManager' | 'worldsManager' | 'notificationService',
     '/world/:world_name/permissions/:permission_name/:address'
   > &
     DecentralandSignatureContext<any>
 ): Promise<IHttpServerComponent.IResponse> {
-  const { namePermissionChecker, permissionsManager, worldsManager, notificationService } = ctx.components
+  const { config, namePermissionChecker, permissionsManager, worldsManager, notificationService } = ctx.components
+  const builderUrl = await config.requireString('BUILDER_URL')
 
   const worldName = ctx.params.world_name
   const permissionName = ctx.params.permission_name as Permission
@@ -188,7 +189,8 @@ export async function putPermissionsAddressHandler(
         title: 'Worlds permission granted',
         description: `You have been granted ${permissionName} permission for world ${worldName}`,
         world: worldName,
-        permissions: [permissionName]
+        permissions: [permissionName],
+        url: `${builderUrl}/worlds?tab=dcl`
       },
       timestamp: Date.now()
     }
@@ -201,12 +203,13 @@ export async function putPermissionsAddressHandler(
 
 export async function deletePermissionsAddressHandler(
   ctx: HandlerContextWithPath<
-    'namePermissionChecker' | 'permissionsManager' | 'worldsManager' | 'notificationService',
+    'config' | 'namePermissionChecker' | 'permissionsManager' | 'worldsManager' | 'notificationService',
     '/world/:world_name/permissions/:permission_name/:address'
   > &
     DecentralandSignatureContext<any>
 ): Promise<IHttpServerComponent.IResponse> {
-  const { namePermissionChecker, permissionsManager, worldsManager, notificationService } = ctx.components
+  const { config, namePermissionChecker, permissionsManager, worldsManager, notificationService } = ctx.components
+  const builderUrl = await config.requireString('BUILDER_URL')
 
   const worldName = ctx.params.world_name
   const permissionName = ctx.params.permission_name as Permission
@@ -248,7 +251,8 @@ export async function deletePermissionsAddressHandler(
         title: 'World permission revoked',
         description: `Your ${permissionName} permission for world ${worldName} has been revoked`,
         world: worldName,
-        permissions: [permissionName]
+        permissions: [permissionName],
+        url: `${builderUrl}/worlds?tab=dcl`
       },
       timestamp: Date.now()
     }

diff --git a/test/integration/permissions-handlers.spec.ts b/test/integration/permissions-handlers.spec.ts
@@ -336,7 +336,7 @@ test('PermissionsHandler', function ({ components, stubComponents }) {
     })
   })
 
-  describe(`PUT and DELETE /world/${worldName}/permissions/[:permission]/[:address]`, function () {
+  describe(`PUT and DELETE /world/:worldName/permissions/[:permission]/[:address]`, function () {
     let alreadyAllowedWallet: Identity
 
     beforeEach(async () => {