Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change bid receive notification #289

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Conversation

meelrossi
Copy link

No description provided.

@meelrossi meelrossi requested a review from a team as a code owner July 30, 2024 19:29
@meelrossi meelrossi force-pushed the feat/change-receive-notif branch from ef8854c to 4b30960 Compare July 30, 2024 19:39
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the linter warnings.

@meelrossi meelrossi force-pushed the feat/change-receive-notif branch from 4b30960 to 13ced3b Compare July 30, 2024 21:11
@meelrossi meelrossi force-pushed the feat/change-receive-notif branch from 13ced3b to e37b054 Compare July 31, 2024 13:32
Copy link

github-actions bot commented Jul 31, 2024

Test this pull request

  • The package can be tested by running
    npm upgrade "https://sdk-team-cdn.decentraland.org/@dcl/schemas/branch/feat/change-receive-notif/dcl-schemas-13.3.2-10216810042.commit-4b4cb06.tgz"

@aleortega
Copy link
Contributor

@meelrossi please let me know once this is merged and ready to integrate with notifications so I can update the definition of the service accordingly to start receiving this events and avoid filtering it out at SNS level.

Related PR

@meelrossi meelrossi merged commit ef293ea into main Aug 5, 2024
4 checks passed
@meelrossi meelrossi deleted the feat/change-receive-notif branch August 5, 2024 13:28
meelrossi added a commit that referenced this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants