Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: performance in allocations and retained size #48

Merged
merged 3 commits into from
May 24, 2022
Merged

fix: performance in allocations and retained size #48

merged 3 commits into from
May 24, 2022

Conversation

menduz
Copy link
Member

@menduz menduz commented May 24, 2022 •
edited
Loading

Did you know that awaited Promise.race inside async iterators won't get garbage collected?

Before:
Screen Shot 2022-05-24 at 10 52 45
Screen Shot 2022-05-24 at 10 54 33

After:
Screen Shot 2022-05-24 at 10 52 51
Screen Shot 2022-05-24 at 10 54 12

@menduz menduz merged commit 1cc95bc into main May 24, 2022
@menduz menduz deleted the chore/performance branch May 24, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@menduz