Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix unified markets query to include proper owner count #276

Merged
merged 3 commits into from
May 1, 2023

Conversation

juanmahidalgo
Copy link
Contributor

@juanmahidalgo juanmahidalgo commented May 1, 2023

This PR address the following things:

  • The owners_count field was getting calculated on the JOIN with the opened orders, so it wasn't accurate. Now it's getting computed on all the NFTs joined with the items.
  • Fixes the getIsOnSale condition: now it also has the logic for "not on sale", when there are no listings and it's either not on sale or sold out.
  • For recently_listed, updates the logic and sorts by the greateast between max_order_created_at and first_listed_at, using the newest field to sort.
  • For chepeast, updates the logic and sorts by first_listed_at as secondary field

@juanmahidalgo juanmahidalgo merged commit b8cd0d0 into master May 1, 2023
@juanmahidalgo juanmahidalgo deleted the fix/unified-markets-query branch May 1, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants