fix: issuedId when tokenURI is null #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinszuchet
pushed a commit
that referenced
this pull request
Apr 13, 2023
* fix: issuedId whtn tokenURI is null * fix: removed unused type
kevinszuchet
added a commit
that referenced
this pull request
Apr 13, 2023
* feat: Augment trendings with favorites data * refactor: Keep reqs in the ports and move only the merge logic into the new utils file * fix: Remove only from test * test: Fix & unskip tests for augmenting trendings with picks * fix: Missing favorites component in the index * Update src/tests/logic/favorites-utils.spec.ts Co-authored-by: Lautaro Petaccio <1120791+LautaroPetaccio@users.noreply.github.com> Signed-off-by: Kevin Szuchet <31735779+kevinszuchet@users.noreply.github.com> * Update src/tests/ports/trendings.spec.ts Co-authored-by: Lautaro Petaccio <1120791+LautaroPetaccio@users.noreply.github.com> Signed-off-by: Kevin Szuchet <31735779+kevinszuchet@users.noreply.github.com> * Update src/tests/ports/trendings.spec.ts Co-authored-by: Lautaro Petaccio <1120791+LautaroPetaccio@users.noreply.github.com> Signed-off-by: Kevin Szuchet <31735779+kevinszuchet@users.noreply.github.com> * Update src/tests/ports/trendings.spec.ts Co-authored-by: Lautaro Petaccio <1120791+LautaroPetaccio@users.noreply.github.com> Signed-off-by: Kevin Szuchet <31735779+kevinszuchet@users.noreply.github.com> * Update src/tests/ports/trendings.spec.ts Co-authored-by: Lautaro Petaccio <1120791+LautaroPetaccio@users.noreply.github.com> Signed-off-by: Kevin Szuchet <31735779+kevinszuchet@users.noreply.github.com> * Update src/tests/ports/trendings.spec.ts Co-authored-by: Lautaro Petaccio <1120791+LautaroPetaccio@users.noreply.github.com> Signed-off-by: Kevin Szuchet <31735779+kevinszuchet@users.noreply.github.com> * Update src/tests/ports/trendings.spec.ts Co-authored-by: Lautaro Petaccio <1120791+LautaroPetaccio@users.noreply.github.com> Signed-off-by: Kevin Szuchet <31735779+kevinszuchet@users.noreply.github.com> * fix: issuedId when tokenURI is null (#269) * fix: issuedId whtn tokenURI is null * fix: removed unused type * refactor: enhanceItemsWithPicksStats fn is not async * styles: Sort imports * chore: Upgrade schemas * test: Add test to check if the trendings are being enhanced with their picks --------- Signed-off-by: Kevin Szuchet <31735779+kevinszuchet@users.noreply.github.com> Co-authored-by: Lautaro Petaccio <1120791+LautaroPetaccio@users.noreply.github.com> Co-authored-by: Florencia Barreto <32873485+flobarreto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.