refactor: New util to fetch same url multiple times to avoid exceeding the max length with one query parameter #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… avoid exceding the max length
LautaroPetaccio
requested changes
Apr 7, 2023
| return (data as PaginatedResponse<T>).results !== undefined | ||
| } | ||
|
|
||
| export async function queryMultipleTimesWhenExceedingUrlLimit<T>( |
There was a problem hiding this comment.
Would you mind adding tests for this new auxiliary function?
src/ports/utils.ts
Outdated
Comment on lines
91
to
92
| const param = | ||
| (alreadyHasQueryParams ? `&` : '') + `${queryParameterName}=${value}` |
There was a problem hiding this comment.
This should, if it's the first element of the array, choose between using ? or & depending on if it already has query parameters or not, and then, for all of the other cases, append &.
As it is here, if the base url doesn't have query parameters, it will concatenate all of the query parameters without the use of &.
Co-authored-by: Lautaro Petaccio <1120791+LautaroPetaccio@users.noreply.github.com> Signed-off-by: Kevin Szuchet <31735779+kevinszuchet@users.noreply.github.com>
kevinszuchet
deleted the
refactor/fn-to-query-multiple-urls-when-exceding-limit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #263