Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: items #21

Merged
merged 3 commits into from
Jul 30, 2021
Merged

fix: items #21

merged 3 commits into from
Jul 30, 2021

Conversation

cazala
Copy link
Member

@cazala cazala commented Jul 30, 2021

  • On the NFT level renamed wearableRarity to itemRarity, so the wearable only properties are prefixed with wearable (like wearableGender and wearableCategory) and the item only properties are prefixed with item (like itemRarity and itemId).

  • On the item level, it is just rarity instead of wearableRarity

  • Fixed bug in item pagination using now createdAt to sort results.

  • Added isOnSale property to items (which is true if the store has been added as minter and the max supply has not been reached)

nicosantangelo
nicosantangelo approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@nicosantangelo nicosantangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@nicosantangelo nicosantangelo merged commit 6d95a8f into master Jul 30, 2021
@nicosantangelo nicosantangelo deleted the fix/items branch July 30, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicosantangelo nicosantangelo nicosantangelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cazala @nicosantangelo