Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: items #20

Merged
merged 41 commits into from
Jul 16, 2021
Merged

feat: items #20

merged 41 commits into from
Jul 16, 2021

Conversation

cazala
Copy link
Member

@cazala cazala commented Jul 13, 2021 •
edited
Loading

IMPORTANT: This is using a release cadidate of @dcl/schemas (decentraland/schemas#8)

Closes #13
Closes #14

Dev env

CORS_ORIGIN=*
CORS_METHOD=*
MARKETPLACE_SUBGRAPH_URL=https://api.thegraph.com/subgraphs/name/decentraland/marketplace-ropsten
COLLECTIONS_SUBGRAPH_URL=https://api.thegraph.com/subgraphs/name/decentraland/collections-matic-mumbai
MARKETPLACE_CHAIN_ID=3
COLLECTIONS_CHAIN_ID=80001

cazala added 30 commits June 22, 2021 17:05
@cazala
feat: use contractAddress and tokenId instead of legacy ids for bids
19e664c
@cazala
wip
6748067
@cazala
Merge branch 'master' into feat/items
1acc947
@cazala
feat: orders
eae9bc6
@cazala
fix: orders
2747fd4
@cazala
chore: reorder
c5aeae2
@cazala
chore: fix tests
12e7810
@cazala
feat: bids
d159a50
@cazala
feat: contracts
ad45957
@cazala
feat: nfts
75439dd
@cazala
feat: browse
c6002a4
@cazala
fix: nfts
7d6261d
@cazala
feat: added count to merger, removed browse
0f07b0c
@cazala
fix: totals
343f971
@cazala
refactor: filters
7add056
@cazala
feat: use tokenId
14b7628
@cazala
fix: sort and pagination on orders and bids
16a6577
@cazala
feat: items
6e72760
@cazala
chore: remove console.log
d22eaf0
@cazala
feat: change response shape
1016f42
@cazala
refactor: namespace
7d36305
@cazala
feat: properties to nft
361a89a
@cazala
chore: added readme
af30329
@cazala
chore: fix test
c7af959
@cazala
chore: update readme
8fbf16d
@cazala
feat: add new filters to items
6d98d19
@cazala
chore: remove console.log
327e599
@cazala
fix: only filter out expired on status open
4f5b80c
@cazala
fix: count when should not fetch should be 0
0830f40
@cazala
fix: nft.issuedId and nft.itemBlockchainId on collections
095ac3b
@cazala cazala marked this pull request as draft July 15, 2021 05:07
@cazala cazala marked this pull request as ready for review July 15, 2021 18:42
@cazala cazala mentioned this pull request Jul 15, 2021
Merged
nicosantangelo
nicosantangelo reviewed Jul 16, 2021
View reviewed changes
Copy link
Contributor

@nicosantangelo nicosantangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs ❤️

src/logic/http/response.ts Outdated Show resolved Hide resolved
src/logic/nfts/collections.ts Outdated Show resolved Hide resolved
src/adapters/sources/bids.ts Outdated Show resolved Hide resolved
src/logic/nfts/marketplace.ts Outdated Show resolved Hide resolved
src/logic/nfts/marketplace.ts Outdated Show resolved Hide resolved
@nicosantangelo nicosantangelo merged commit 1dbda63 into master Jul 16, 2021
@nicosantangelo nicosantangelo deleted the feat/items branch July 16, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicosantangelo nicosantangelo nicosantangelo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add creator to Items and NFTs Add a mint number for wearables
2 participants
@cazala @nicosantangelo