feat: Rentals NFT Component #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzavalia
force-pushed
the
feat/rentals-nft-component
branch
from
ec19aca
to
201062f
Compare
Co-authored-by: Juanma Hidalgo <juanma06@gmail.com>
Co-authored-by: Juanma Hidalgo <juanma06@gmail.com>
…_in no matter the amount of elements
LautaroPetaccio
requested changes
Nov 14, 2022
| lessors: [options.owner!], | ||
| contractAddresses: [contractAddresses.land, contractAddresses.estate], | ||
| isClaimed: false, | ||
| // In order to avoid pagination issues, we need to fetch all the assets for this owner in the rentals subgraph. |
There was a problem hiding this comment.
Would you mind creating a ticket to fix this eventually? We might forget about it and it could come in handy to have it recorded somewhere.
| } | ||
|
|
||
| // This function is currently not needed for the current use cases of this component so it will always return an empty array. | ||
| async function fetchByTokenIds(_tokenIds: string[]): Promise<NFTResult[]> { |
There was a problem hiding this comment.
What if you make fetchByTokenIds optional in the INFTsComponent type?
There was a problem hiding this comment.
Is it really necessary?
Co-authored-by: Lautaro Petaccio <1120791+LautaroPetaccio@users.noreply.github.com>
Co-authored-by: Lautaro Petaccio <1120791+LautaroPetaccio@users.noreply.github.com>
Co-authored-by: Lautaro Petaccio <1120791+LautaroPetaccio@users.noreply.github.com>
Co-authored-by: Lautaro Petaccio <1120791+LautaroPetaccio@users.noreply.github.com>
* feat: Rental status option * feat: Remove rental status from source instantiation * feat: Get rental status to enhance nfts from query params * chore: Fix test * chore: Refactor logic for status
LautaroPetaccio
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #150
Added rentalsNFTComponent in charge of looking for assets that belonged to a certain user that are currently locked in the rentals contract.
With this component, any nft search with owner and isLand query params will also return the lands in the rentals contract that have lessor as the provided owner.