fix: Improve NFT fetch performance on rentals #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cazala
approved these changes
Aug 24, 2022
cazala
reviewed
Aug 24, 2022
src/adapters/sources/rentals.ts
Outdated
| const tokenIdsOfRentals = rentals.map((rental) => rental.nftId) | ||
| const nftResultsOfRentals = await nfts.fetchByTokenIds(tokenIdsOfRentals) | ||
| const nftResultsOfRentalsById = Object.fromEntries( | ||
| nftResultsOfRentals.map((nft) => [nft.nft.id, nft]) |
There was a problem hiding this comment.
just a heads up, this is looping the nftResultsOfRentals twice (one for the map and another for the fromEntries) and creating N arrays + 1 object. Using a .reduce would loop only once and create just 1 object.
There was a problem hiding this comment.
If this is meant just for a single page of 20 elements might not make a difference but for 1000 results it could.
There was a problem hiding this comment.
Changed to a reduce!
LautaroPetaccio
deleted the
fix/improve-nft-fetch-performance-on-rentals
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the NFT fetching procedure when rentals are requests by using
id_in.This PR also fixes the should fetch function of the rentals source to check the
isLandparameter when there's no category set.