fix: Add support for the signature server integration #124
Conversation
| @@ -2,6 +2,7 @@ CORS_ORIGIN=* | |||
| CORS_METHOD=* | |||
| MARKETPLACE_SUBGRAPH_URL=https://api.thegraph.com/subgraphs/name/decentraland/marketplace | |||
| COLLECTIONS_SUBGRAPH_URL=https://api.thegraph.com/subgraphs/name/decentraland/collections-matic-mainnet | |||
| SIGNATURES_SERVER_URL=http://localhost:3000 | |||
There was a problem hiding this comment.
is this intentional or did this slip thru?
There was a problem hiding this comment.
We can add whatever we want here as it's only for the specs, so I added a localhost site, but it could be anything we want.
There was a problem hiding this comment.
yea but once the signatures server is live it should be something like https://signatures-api.decentraland.org right? Otherwise you need to have your own local instance running
| rental.tokenId | ||
| ) | ||
| if (!nftResult) { | ||
| throw new Error('NFT for the rental listing was not found') |
There was a problem hiding this comment.
Should the whole request fail if one nft is not found? Or should we filter them out? I honestly don't know the answer lol, but I figured asking would not hurt.
There was a problem hiding this comment.
That's a great question, filtering the item if the NFT doesn't exist would work, but that shouldn't ever happen, I mean, there can't be a listing without a NFT. Allowing listings to be created without NFTs might be a pretty big bug, we would like to know if this is happening I guess. What do you think?
There was a problem hiding this comment.
Okay! As long as the signature server doesn't allow the creation of rents for nfts that are not part of the nft-server then I guess it's not an issue
Closes #63