feat: add missing data to /about endpoint #121
Conversation
hugoArregui
changed the title
| @@ -11,6 +11,9 @@ HTTP_SERVER_PORT=3000 | |||
| HTTP_SERVER_HOST=0.0.0.0 | |||
| NATS_URL=localhost:4222 | |||
| LAMBDAS_URL= | |||
| LIGHTHOUSE_URL= | |||
| CONTENT_URL= | |||
There was a problem hiding this comment.
what's this used for? Should it be able to reach an outside content server?
There was a problem hiding this comment.
no, it's all internal, for the status check, I'll map them in catalyst-owner
| @@ -11,6 +11,9 @@ HTTP_SERVER_PORT=3000 | |||
| HTTP_SERVER_HOST=0.0.0.0 | |||
| NATS_URL=localhost:4222 | |||
| LAMBDAS_URL= | |||
| LIGHTHOUSE_URL= | |||
There was a problem hiding this comment.
what's this used for? Should it be able to reach an outside lighthouse server?
There was a problem hiding this comment.
no, it's all internal, for the status check, I'll map them in catalyst-owner
There was a problem hiding this comment.
can we use the same name for the env var then?
| }, | ||
| bff: { | ||
| healthy: true, | ||
| commitHash: await config.getString('COMMIT_HASH'), |
There was a problem hiding this comment.
are we sure that this env var is always present? Also, in the catalyst owner is this the name or is it something BFF-related?
There was a problem hiding this comment.
it's in the image, but if not present it will return undefined, which is what the type expects
There was a problem hiding this comment.
can we change the name to something more specific? Like BFF_COMMIT_HASH?
There was a problem hiding this comment.
Co-authored-by: Agustina Aldasoro <agusaldasoro@users.noreply.github.com>
Co-authored-by: Agustina Aldasoro <agusaldasoro@users.noreply.github.com>
Co-authored-by: Agustina Aldasoro <agusaldasoro@users.noreply.github.com>
| @@ -11,6 +11,9 @@ HTTP_SERVER_PORT=3000 | |||
| HTTP_SERVER_HOST=0.0.0.0 | |||
| NATS_URL=localhost:4222 | |||
| LAMBDAS_URL= | |||
| LIGHTHOUSE_URL= | |||
There was a problem hiding this comment.
can we use the same name for the env var then?
| }, | ||
| bff: { | ||
| healthy: true, | ||
| commitHash: await config.getString('COMMIT_HASH'), |
There was a problem hiding this comment.
can we change the name to something more specific? Like BFF_COMMIT_HASH?
There is a tricky thing going on here, we need every catalyst node to run this version with comms v2 at least once so the catalyst-name is persisted (unless they defined the LIGHTHOUSE_NAMES env var)