chore: replace cluster status and explorer configuration with about handler #111

hugoArregui · 2022-07-14T14:41:26Z

The about endpoint will return:

Comms version
Service health (by querying lambda if v2, or querying lambda + archipelago status discovery if v3)

…andler

src/controllers/handlers/about-handler.ts

agusaldasoro · 2022-07-15T12:42:37Z

src/controllers/handlers/about-handler.ts

+  }
+
+  try {
+    const response = await fetch.fetch(`${lambdasUrl}/health`, {


should we check the response code here too?

I don't think so, I added some unit tests

agusaldasoro · 2022-07-15T12:45:16Z

src/controllers/handlers/about-handler.ts

+
+    const data: Record<string, string> = await response.json()
+
+    body.content.healthy = data['content'] === 'Healthy'


if data['content'] is undefined this will be false, right?

yes, I added some unit tests

chore: replace cluster status and explorer configuration with about h…

6d5f637

…andler

hugoArregui requested a review from agusaldasoro July 14, 2022 14:41

addressing review comments

9309730

agusaldasoro approved these changes Jul 15, 2022

View reviewed changes

hugoArregui merged commit fb73ee6 into main Jul 15, 2022

hugoArregui deleted the chore/about-handler branch July 15, 2022 17:38

Provide feedback


		const data: Record<string, string> = await response.json()

		body.content.healthy = data['content'] === 'Healthy'