Skip to content

Commit

Permalink
fix: linter (#274)
Browse files Browse the repository at this point in the history
  • Loading branch information
marianogoldman authored Feb 5, 2024
1 parent 71d496a commit c8696c1
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 6 deletions.
11 changes: 10 additions & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@dcl/eslint-config",
"extends": "@dcl/eslint-config/sdk",
"parser": "@typescript-eslint/parser",
"parserOptions": {
"ecmaVersion": 2020, // Allows for the parsing of modern ECMAScript features
Expand All @@ -9,5 +9,14 @@
"./tsconfig.json",
"./test/tsconfig.json"
]
},
"rules": {
"prettier/prettier": ["error", {
"printWidth": 120,
"semi": false,
"singleQuote": true,
"trailingComma": "none",
"tabWidth": 2
}]
}
}
2 changes: 1 addition & 1 deletion src/validations/access/common/items.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ function alreadySeen(resolvedPointers: SupportedAsset[], parsed: SupportedAsset)
function resolveSameUrn(alreadyParsed: SupportedAsset, parsed: SupportedAsset): boolean {
const { ['uri']: uri1, ...alreadyParsedWithoutUri } = alreadyParsed
const { ['uri']: uri2, ...parsedWithoutUri } = parsed
return JSON.stringify(parsedWithoutUri) == JSON.stringify(alreadyParsedWithoutUri)
return JSON.stringify(parsedWithoutUri) === JSON.stringify(alreadyParsedWithoutUri)
}

async function parseUrnNoFail(urn: string): Promise<SupportedAsset | null> {
Expand Down
2 changes: 1 addition & 1 deletion src/validations/access/subgraph/scenes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ export function createSceneValidateFn({
const parcel = await getParcel(x, y, timestamp)
if (parcel) {
const belongsToEstate: boolean =
parcel.estates != undefined && parcel.estates.length > 0 && parcel.estates[0].estateId != undefined
parcel.estates !== undefined && parcel.estates.length > 0 && parcel.estates[0].estateId !== undefined

return (
(await hasAccessThroughFirstLevelAuthorities(parcel, ethAddress)) ||
Expand Down
2 changes: 1 addition & 1 deletion src/validations/entity-structure.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { DeploymentToValidate, OK, validationFailed, ValidationResponse } from '
*/
export async function entityStructureValidationFn(deployment: DeploymentToValidate): Promise<ValidationResponse> {
const { entity } = deployment
if (new Set(entity.pointers).size != entity.pointers.length) {
if (new Set(entity.pointers).size !== entity.pointers.length) {
return validationFailed('There are repeated pointers in your request.')
} else if (!entity.pointers || entity.pointers.length <= 0) {
return validationFailed('The entity needs to be pointed by one or more pointers.')
Expand Down
1 change: 0 additions & 1 deletion test/unit/validations/items/emotes.spec.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { EntityType } from '@dcl/schemas'
import sharp from 'sharp'
import {
emoteRepresentationContentValidateFn,
wasCreatedAfterADR74ValidateFn
Expand Down
1 change: 0 additions & 1 deletion test/unit/validations/items/wearables.spec.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { EntityType } from '@dcl/schemas'
import sharp from 'sharp'
import {
createDeploymentMaxSizeExcludingThumbnailIsNotExceededValidateFn,
createThumbnailMaxSizeIsNotExceededValidateFn
Expand Down

0 comments on commit c8696c1

Please sign in to comment.