Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert readyToUse in health endpoint #932

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Conversation

0xJuancito
Copy link
Contributor

@0xJuancito 0xJuancito commented Feb 18, 2022

Description

The recently added readyToUse attribute in #927 breaks the current kernel implementation, as it is expecting all the attributes from the object returned by the health endpoint to be Healthy: https://github.com/decentraland/kernel/blob/afd06bd9837cb355b3ef62bde4fce77e0e02aa9e/packages/shared/dao/index.ts#L90-L97

Reverting this until a change is made on the kernel repository

Fix #933

Changes

Specify the behavior changes introduced by this pull request

  • Remove readyToUse in lambdas health endpoint

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change). If there's an API change, link the pull request in the API spec repository and the accepted DAO governance poll
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@0xJuancito 0xJuancito merged commit a5e1df8 into main Feb 18, 2022
@0xJuancito 0xJuancito deleted the fix/revert-ready-to-use branch February 18, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explorer breaks because of change in health endpoint
2 participants