Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove from/to LocalTimestamp deprecated query params #924

Merged
merged 5 commits into from
Feb 18, 2022

Conversation

agusaldasoro
Copy link
Contributor

Remove deprecated old params fromLocalTimestamp & toLocalTimestamp from /deployments & /pointer-changes

@menduz
Copy link
Member

menduz commented Feb 15, 2022

@agusaldasoro
Copy link
Contributor Author

agusaldasoro commented Feb 15, 2022

Please consider updating this first https://github.com/decentraland/snapshots-fetcher/blob/66b24b2b2a8d5df11a6757baed52f7ac2a5e6ed5/src/client.ts#L46

There's no need to. This PR affects only clients using toLocalTimestamp or fromLocalTimestamp query parameters.
If the client is already using from/to + sortingField, then the query is "smart" enough to do what it needs: https://github.com/decentraland/catalyst/blob/main/content/src/logic/database-queries/deployments-queries.ts#L175

agusaldasoro and others added 2 commits February 17, 2022 10:32
@agusaldasoro agusaldasoro merged commit 5d426f4 into main Feb 18, 2022
@agusaldasoro agusaldasoro deleted the remove-old-params branch February 18, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants