chore: reduce off chain refresh time #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agusaldasoro
suggested changes
Jan 26, 2022
| @@ -23,7 +23,7 @@ export class OffChainWearablesManager { | |||
| }) { | |||
| this.definitions = new TimeRefreshedDataHolder( | |||
| () => OffChainWearablesManager.fetchOffChain(client, collections ?? DEFAULT_COLLECTIONS), | |||
| refreshTime ?? '1d' | |||
| refreshTime ?? '15m' | |||
There was a problem hiding this comment.
Suggested change
| refreshTime ?? '15m' | |
| refreshTime |
And make refreshTime not optional parameter
agusaldasoro
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deploying changes for the off chain wearables is taking a long time because results are cached for one day, making it difficult to check if what was deployed is correct, and also for testing and iterating. The goal of this PR is to reduce that time to a number that helps with these issues, while not impacting the catalyst performance.
Changes
1 dayto15 minutes