feat: update error when failed deployment retry fails #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agusaldasoro
approved these changes
Jan 26, 2022
| @@ -44,6 +51,10 @@ export async function retryFailedDeploymentExecution( | |||
| DeploymentContext.FIX_ATTEMPT | |||
| ) | |||
| } catch (error) { | |||
| // it failed again, override failed deployment error description | |||
There was a problem hiding this comment.
Are you sure that if the deployment fails throws an exception? Can it fail without throwing an error?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update failed deployment error description when retry task fails to fix it.
Fixing a failed deployment will be ignored when there are newer entities with same pointer and it will be removed from the cache.