Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cached images for new uploads #925

Merged
merged 2 commits into from
Jan 3, 2018
Merged

Use cached images for new uploads #925

merged 2 commits into from
Jan 3, 2018

Conversation

tech4him1
Copy link
Contributor

@tech4him1 tech4him1 commented Dec 14, 2017

- Summary

Before we had the media library, we used uploaded image data directly when it was first uploaded, since it was likely not deployed yet. With the media library, we should be able to do this as well.

@erquhart Is this the correct fix, or do we need more in-depth changes?

- Test plan

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@verythorough
Copy link
Contributor

verythorough commented Dec 14, 2017

Deploy preview ready!

Built with commit 868e57b

https://deploy-preview-925--netlify-cms-www.netlify.com

@verythorough
Copy link
Contributor

verythorough commented Dec 14, 2017

Deploy preview ready!

Built with commit 868e57b

https://deploy-preview-925--cms-demo.netlify.com

@tech4him1 tech4him1 changed the title WIP: Use cached images for new uploads Use cached images for new uploads Jan 2, 2018
Copy link
Contributor

@erquhart erquhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, works locally.

@erquhart erquhart merged commit 4515edd into master Jan 3, 2018
@erquhart erquhart deleted the fix-new-uploads branch January 3, 2018 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants