Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #846 Backspace removes empty blocks #854

Merged
merged 2 commits into from
Nov 30, 2017

Conversation

Dammmien
Copy link
Contributor

@Dammmien Dammmien commented Nov 30, 2017

- Summary
Fixes #846 Backspace removes empty blocks

- Description for the changelog

  • onKeyDown takes 2 arguments, not 3.
  • And backspace starts with an uppercase.
  • Consequently others functions SoftBreak, BreakToDefaultBlock should have the issue.

@erquhart
Copy link
Contributor

erquhart commented Nov 30, 2017

onKeyDown is a Slate method, you can read more about it here. It used to include a data object that aliased keys, hence the lowercase "backspace", but it seems I missed a breaking change where it was removed in slate-react 0.6.0.

You're right that this needs to hit other plugins, thanks for pointing it out!

Also related, we should probably start using is-hotkey at some point to further simplify things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants