Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add private media library for integrations #834

Merged
merged 1 commit into from
Nov 19, 2017
Merged

Conversation

erquhart
Copy link
Contributor

@erquhart erquhart commented Nov 19, 2017

For users of custom asset store integrations, "private" assets requiring authentication for read access can be uploaded through the CMS. This PR adds media library support for private asset handling:

  • Switches to a "private" mode when launched from an image or file widget configured as private
  • Resets media library state to default when switching in and out of private mode
  • Ignores async media library state changes from that did not originate from the current mode
  • Visually distinct so the user knows they're viewing private assets

There is a possibility that a user could experience non-destructive bugs by initiating a long async request, like an upload, and then switching modes twice to arrive back in the same mode before the request finishes. Documented in #835.

@erquhart erquhart merged commit 9569f18 into master Nov 19, 2017
@erquhart erquhart deleted the private-media-library branch November 19, 2017 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant