Do not infer file format if collection specified. #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tech4him1
force-pushed
the
763-format-override
branch
from
d56e925
to
bf106f5
Compare
tech4him1
changed the title
erquhart
suggested changes
Nov 27, 2017
|
Sounds good, it really is a breaking change by definition. |
Before, we always tried to infer a file's format, even if it was explicitly specified in the collection's config. This commit makes it so that we always use the format from the config if it is specified, and only if it is not set do we try to infer it from the file extension.
tech4him1
force-pushed
the
763-format-override
branch
from
bf106f5
to
35c6242
Compare
erquhart
approved these changes
Dec 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Before, we always tried to infer a file's format, even if it was
explicitly specified in the collection's config. This commit makes it so
that we always use the format from the config if it is specified, and
only if it is not set do we try to infer it from the file extension.
Fixes #763.
NOTE: Please review this fairly intensely -- I really don't want to break anything (don't think you are either).
- Test plan
Used CMS
/example, as well as test case in the related issue.- Description for the changelog
Do not infer file format if collection specified.
- A picture of a cute animal (not mandatory but encouraged)