Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable login button while login is in progress. #741

Merged
merged 1 commit into from
Nov 7, 2017

Conversation

tech4him1
Copy link
Contributor

- Summary

Since the authentication can occur in another window, or it can occur behind the scenes when restoring locally saved credentials, the login button should be disabled while the login is running. This makes it clearer for the user.

- Test plan

Login works normally. The login button is disabled while logging in (or restoring login).

- Description for the changelog

Disable login button while login is in progress.

- A picture of a cute animal (not mandatory but encouraged)

@tech4him1 tech4him1 force-pushed the disable-login-button-while-working branch 3 times, most recently from b8a5011 to 2e6a5ef Compare October 26, 2017 02:30
@tech4him1 tech4him1 force-pushed the disable-login-button-while-working branch from 2e6a5ef to 7225a12 Compare October 26, 2017 02:32
@tech4him1 tech4him1 changed the title WIP: Disable login button while login is in progress. Disable login button while login is in progress. Oct 27, 2017
@tech4him1 tech4him1 changed the title Disable login button while login is in progress. WIP: Disable login button while login is in progress. Oct 27, 2017
@tech4him1 tech4him1 changed the title WIP: Disable login button while login is in progress. Disable login button while login is in progress. Oct 27, 2017
Copy link
Contributor

@Benaiah Benaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tech4him1
Copy link
Contributor Author

Just a note: this has not been implemented for Identity, as that flow is kind-of separate and uses a modal anyway.

@Benaiah
Copy link
Contributor

Benaiah commented Oct 27, 2017

@tech4him1 understood, thanks.

@erquhart erquhart merged commit c707228 into master Nov 7, 2017
@erquhart erquhart deleted the disable-login-button-while-working branch November 7, 2017 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants