(WIP) Repeatable and collapsible widgets #468
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benaiah
force-pushed
the
repeating-widgets
branch
from
e944b9c to
3d4f128
Compare
Benaiah
force-pushed
the
repeating-widgets
branch
from
3d4f128 to
f204440
Compare
|
@Benaiah is this PR still viable? |
This was referenced Mar 5, 2018
Closed
|
Closing as stale. @Benaiah I'll leave deleting the branch to you in case you want to save any of the work on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Adds
repeatableandcollapsibleHOCs for widgets that allow the functionality previously tied toListControlto be used on arbitrary widgets.TODO:
repeatableusereact-sortable-hocand use drag handlesListControlcssListControlto userepeatableandcollapsible- Test plan
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)