Upload images as part of editorial workflow #2397
Conversation
- Use the existing slugFormatter() in backend.js - Don't require a title (instead require whatever is needed to create the slug - Remove some console log stuff
|
Preview proposed changes to the CMS demo site in the link below: Built with commit e56e35c |
|
Preview proposed changes to netlifycms.org in the link below: Built with commit e56e35c |
|
Hey @samlanning thanks for your hard work on this one, looks certainly like something that we want to use (uploading images as part of the PR as we don't allow commits direct to master) I've straight away run into a problem wherein it looks like I've accidentally changed my PR into a |
|
@samlanning any thoughts on what @wakeless ran into? |
|
Sorry for not replying to this sooner. Yeah that makes sense, I think the best way to solve for this would probably be to only allow media to be uploaded once a draft post has been "saved", and a PR opened, then using that existing PR. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request is still a bit of a work-in-progress, but I wanted to open a PR here to start a discussion on what needs to be done before we can get this merged in.
This Addresses issue #1344 by allowing users to upload images as part of an editorial workflow, which adds the images to the same branch as collection content, allowing for a couple of things:
This has currently only been tested with GitHub, it probably doesn't work on other backends at the moment, this will need to be tested first. It's based on the work of @ro-savage in Encrypt-S@a86b5e8, but has been rebased ontop of the latest code, and cleaned up a little bit.
Later on down the line, if the editorial workflow is updated to be compatible with fork-and-pr workflows on GitHub, these changes should automatically work there too.