Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs menu sections #1366

Merged
merged 1 commit into from
May 17, 2018
Merged

add docs menu sections #1366

merged 1 commit into from
May 17, 2018

Conversation

erquhart
Copy link
Contributor

  • Splits docs menu into "Quick Start", "Guides", "Reference", and "Contributing" sections.
  • Uses Hugo's built in menu functionality
  • Removes extraneous list.html template for docs and updates single.html to cover all cases (we don't actually have a list view, it was mostly duplicate code).

This will need to be ported into the upcoming Gatsby rewrite (cc @zebapy), but this is from a while ago and should be replicated in any migration.

@verythorough
Copy link
Contributor

verythorough commented May 17, 2018

Deploy preview for cms-demo ready!

Built with commit e684896

https://deploy-preview-1366--cms-demo.netlify.com

@verythorough
Copy link
Contributor

Deploy preview for netlify-cms-www ready!

Built with commit 0bed27e

https://deploy-preview-1366--netlify-cms-www.netlify.com

@verythorough
Copy link
Contributor

Deploy preview for netlify-cms-www ready!

Built with commit e684896

https://deploy-preview-1366--netlify-cms-www.netlify.com

@erquhart erquhart merged commit c1c3055 into decaporg:master May 17, 2018
@erquhart erquhart deleted the docs-menu branch May 17, 2018 21:14
erquhart added a commit that referenced this pull request May 17, 2018
@verythorough
Copy link
Contributor

Woot! Glad to see this improvement. I may propose some changes to the groupings, but any grouping at all is a huge boost. :)

@zebapy
Copy link
Contributor

zebapy commented May 18, 2018

@erquhart So architecture.md and customization.md are excluded from menu on purpose now?

@verythorough
Copy link
Contributor

Ah, good point! I suspect this may be because these changes were originally part of the Preview API docs PR, #1311. Until the new Preview API is implemented, though, I imagine we want to keep the docs for the current API in place.
I'm thinking maybe Architecture could go under "Contributing," and customization.md would be "Creating Custom Previews" under "Guides."

zebapy added a commit to zebapy/netlify-cms that referenced this pull request May 18, 2018
@erquhart
Copy link
Contributor Author

Good catch @zebapy, I'll add those back.

brianlmacdonald pushed a commit to brianlmacdonald/netlify-cms that referenced this pull request May 23, 2018
erquhart pushed a commit to zebapy/netlify-cms that referenced this pull request Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants