-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding inference field #1355
Adding inference field #1355
Conversation
Deploy preview for cms-demo ready! Built with commit e7bf928 |
Deploy preview for netlify-cms-www ready! Built with commit e7bf928 |
This would be a breaking change (a minor one, I know), so we can't merge and release it under v1. Folks should be able to override the inferences though, opening an issue to discuss that would be a great next step to solving the underlying problem. |
How is this a breaking change? It's adding an element to the array... |
If someone is using one of the field names that come afterward, such as 'thumbnail', but also had a field named 'cover', the cover field would now be used instead of the thumbnail field. In the application UI, that's a breaking change. That said, if you just add it last in the array, that should work. Wouldn't break any existing image field inferences. |
Moving to the end of the array
Updated it to add the item at the end of the array |
- Summary
The list of fields to infer is kind of arbitrary. The hugo theme I'm using uses
cover
as the item cover image.Would have been nice is this was configurable.
- Test plan
This doesn't require a test plan.
- Description for the changelog
Adding alternate name for thumbnail image.
- A picture of a cute animal (not mandatory but encouraged)
░░░░░░░░░░░░░░░░░░░░░░░░░
░░░░░░░░▄▀▀▄░░░░░░░░░░░░░
░░░░░░▄▀▒▒▒▒▀▄░░░░░░░░░░░
░░░░░░░▀▌▒▒▐▀░░░░░░░░░░░░
░▄███▀░◐░░░▌░░░░░░░░░░░░░░
░░░▐▀▌░░░░░▐░░░░░░░░░░▄▀▀▀▄▄
░░▐░░▐░░░░░▐░░░░░░░░░█░▄█▀
░░▐▄▄▌░░░░░▐▄▄░░░░░░█░░▄▄▀▀▀▀▄
░░░░░░▌░░░░▄▀▒▒▀▀▀▀▄▀░▄▀░▄▄▄▀▀
░░░░▐░░░░▐▒▒▒▒▒▒▒▒▀▀▄░░▀▄▄▄░▄
░░░░▐░░░░▐▄▒▒▒▒▒▒▒▒▒▒▀▄░▄▄▀▀
░░░░░▀▄░░░░▀▄▒▒▒▒▒▒▒▒▒▒▀▄
░░░░░░░▀▄▄░░░█▄▄▄▄▄▄▄▄▄▄▄▀▄
░░░░░░░░░░▀▀▄▄▄▄▄▄▄▄▀▀░
░░░░░░░░░░░░▌▌░▌▌░░░
░░░░░░░░░░▄▄▌▌▄▌▌