Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: original managed IP cannot be deleted with 2 or more managed IPs present #12

Closed
TBT-TBT opened this issue Aug 23, 2021 · 28 comments
Closed
Labels
priority-high After critical issues are fixed, these should be dealt with before any further issues.

Comments

@TBT-TBT
Copy link

TBT-TBT commented Aug 23, 2021

Bug Report

ZeroUI version:

latest

Current behavior:

In the "members" area of a network, the first given "managed IP" cannot be deleted, even if one or more further IPs are in the managed IPs list.

e.g:
172.30.36.203 (first managed IP)
172.30.36.204 (additional IP)
172.30.36.205 (additional IP)

bug: 172.30.36.203 cannot be deleted

Expected behavior:

deletion of first IP possible after at least a second IP is added:

172.30.36.203 (first managed IP)
172.30.36.204 (additional IP)

--> 172.30.36.203 should be allowed to delete, after deletion 172.30.36.204 should not be able to delete.

Steps to reproduce:

add further IPs to a member, try to delete the first IP.

@dec0dOS
Copy link
Owner

dec0dOS commented Aug 24, 2021

Yes, that is the web application bug, it should be fixed. Thanks for reporting, I'll try to look into it.

@dec0dOS dec0dOS added the bug label Aug 24, 2021
@github-actions
Copy link

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍.
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale label Sep 23, 2021
@TBT-TBT
Copy link
Author

TBT-TBT commented Sep 24, 2021

Regarding the Github bot: the bug is still there.

@github-actions github-actions bot removed the stale label Sep 25, 2021
@github-actions
Copy link

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍.
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale label Oct 26, 2021
@TBT-TBT
Copy link
Author

TBT-TBT commented Oct 26, 2021

Regarding the Github bot: the bug is still there.

@github-actions github-actions bot removed the stale label Oct 27, 2021
@knightian
Copy link

Yep encountered this today

@github-actions github-actions bot removed the bug label Nov 10, 2021
@dec0dOS dec0dOS added the priority-high After critical issues are fixed, these should be dealt with before any further issues. label Nov 11, 2021
@techroy23
Copy link

Bug still present fresh install on docker compose 2.1.1, ubuntu 20.04

@techroy23
Copy link

Update :
I was able to remove the assigned IP by
1a.) Clicking forget in the client
2.) De-auth client in UI
3.) Delete client in UI
4.) Manually add the client in UI
5.) Add the desired IP first before checking the box to authorize.
6.) Enter network ID in Client.

@TBT-TBT
Copy link
Author

TBT-TBT commented Nov 13, 2021

Update : I was able to remove the assigned IP by 1a.) Clicking forget in the client 2.) De-auth client in UI 3.) Delete client in UI 4.) Manually add the client in UI 5.) Add the desired IP first before checking the box to authorize. 6.) Enter network ID in Client.

Well, that is a workaround, but no bugfix / normal behaviour. ZT Central allows that without anything special.

@drtech981
Copy link

Still having this issue a fresh install on Ubuntu 20.04 Docker Version 20.10.11, any updates ?

@drtech981
Copy link

Issue still persists in zero-ui:1.1.5 docker image. Original IP cannot be removed even if other IPs are manually added.

@dec0dOS
Copy link
Owner

dec0dOS commented Dec 17, 2021

Did you really update the image? It works fine for me now. You could check the member settings for "Tags and Caps" feature, it was added in the 1.1.0 release.

Снимок экрана 2021-12-17 в 15 45 12

In the future after few changes you could check the version number in the UI itself.

@TBT-TBT
Copy link
Author

TBT-TBT commented Dec 17, 2021

I can confirm that the issue is indeed solved with the tag :latest (auto update with Watchtower).

Thank you very much, @dec0dOS ! I appreciate this bugfix very much and can now really switch to Zero-UI for my Controller, as I can now model my networks with the IP addresses as they are on MyZT.com.

@drtech981
Copy link

@dec0dOS Yes, I can see tags and capabilities in the added options field for each client. Even today I repulled the latest image and the issue still persists.
If I join a client by entering the network address, as soon as I Authorize it, it gets an IP assigned automatically which cannot be deleted even if additional IPs are assigned.

The only way to circumwent this is to first add the memer ID to the controller, assign the IPs, then authorize the client and then finally enter the network address in the clients Zerotier One UI/CLI.

@TBT-TBT
Copy link
Author

TBT-TBT commented Dec 17, 2021

It definitely works. Let the member apply for a join, auth the member, add a second IP manually, with the last position of your choosing, press "+". You will see 2 IPs on the client side. Then remove the autoassigned IP. BINGO!

@bodleytunes
Copy link

Did you really update the image? It works fine for me now. You could check the member settings for "Tags and Caps" feature, it was added in the 1.1.0 release.

Снимок экрана 2021-12-17 в 15 45 12

In the future after few changes you could check the version number in the UI itself.

Hi,

Not sure if I'm missing something but I'm trying to upgrade and I'm not seeing those new tag features?

I've changed the tag in the docker-compose file and pulled, rebuilt and restarted and everything is the same.

Cheers,
Jon.

@dec0dOS
Copy link
Owner

dec0dOS commented Dec 17, 2021

@bodleytunes that is strange. Try to clean the browser cache (or use another browser).

@bodleytunes
Copy link

the same using new browser edge, create new network joined a user, same stuff. I'm using tag 1.1.0 not 1.1.5 ? which one is the latest?

@bodleytunes
Copy link

assuming 1.1.5 ?

@dec0dOS
Copy link
Owner

dec0dOS commented Dec 17, 2021

Yeah, 1.1.5

@bodleytunes
Copy link

will try

@bodleytunes
Copy link

image

@bodleytunes
Copy link

Just rebuilt from scratch using new docker volumes and still the same
image

@bodleytunes
Copy link

And cleared browser cache

@dec0dOS
Copy link
Owner

dec0dOS commented Dec 17, 2021

Try the "latest" tag

@bodleytunes
Copy link

sorted, I had to delete a load of old images and rebuild everything from scratch then it worked. 👍🏻

@TBT-TBT
Copy link
Author

TBT-TBT commented Dec 17, 2021

Guys, it works. Definitely. If it doesn't on your end, the problem is on your end. So please don't make @dec0dOS fix your problems, he did a great job fixing this bug.

@drtech981
Copy link

@TBT-TBT I did a reinstall of the zero-ui and the controller, and now delete IP option is working fine ! Thanks @dec0dOS for this awesome project !

@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2022
dand-oss pushed a commit to dand-oss/zero-ui that referenced this issue Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-high After critical issues are fixed, these should be dealt with before any further issues.
Projects
None yet
Development

No branches or pull requests

6 participants