Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require supports-color <9 #977

Closed
wants to merge 1 commit into from
Closed

Require supports-color <9 #977

wants to merge 1 commit into from

Conversation

stefee
Copy link

@stefee stefee commented Nov 10, 2024

Fixes #975

require('supports-color') in debug/src/node.js should require the CommonJS version of the supports-color package (version 8 or below) rather than ESM, because this package uses CommonJS modules.

requireing ESM modules/packages from CommonJS modules is still experimental and "not recommended in production environments".

@stefee
Copy link
Author

stefee commented Nov 10, 2024

Reviewing what's changed since the last v8 release: chalk/supports-color@v8.1.1...v9.4.0

Notable things that might regress as a result of downgrading to v8:

@stefee stefee closed this Dec 10, 2024
@stefee stefee deleted the patch-1 branch December 10, 2024 19:12
@Qix-
Copy link
Member

Qix- commented Dec 11, 2024

Thanks for the attempt, I appreciate the PR either way. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

debug causes npm to always issue an experimental ESM warning in node 23
3 participants