Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQLAlchemy version to v1.4.27, as v1.4.28 #1114

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Conversation

robintw
Copy link
Collaborator

@robintw robintw commented Dec 14, 2021

🧰 Issue

Fixes #1112.

🚀 Overview:

SQLAlchemy v1.4.28 emits more warnings in various situations (see here. These warnings are triggered by various geoalchemy functions we use. In our CI, we have it set to turn warnings into errors - which is a good idea in general, but means that we can get unexpected errors from dependencies being upgraded by minor point releases which change warnings rules.

The requirement for SQLAlchemy just required v1.4.x, which is normally ok as breaking changes shouldn't occur in a point release - but this doesn't apply to warnings. So, this PR fixes the version to v1.4.27.

There is already a PR in geoalchemy2 to fix these warnings, so once that PR is merged and a new version is released, then we can stop fixing the point version.

🤔 Reason:

Fix CI.

🔨Work carried out:

  • Fix version of SQLAlchemy
  • Tests pass

Confirmations

  • I have chosen reviewers for my PR.
  • I have chosen an appropriate label for the PR, adding interactive_review if reviewers will need to see UI
  • I have extended/updated the documentation in \docs folder
  • Any database content changes (Create, Edit, Delete) are recorded in the Log/Changes tables
  • Any database schema changes are implemented via alembic revision transitions
  • I have completed the mandatory sections of this document.
  • I have deleted any unused sections.

📝 Developer Notes:

@robintw robintw requested a review from IanMayo December 14, 2021 13:47
@IanMayo IanMayo temporarily deployed to pepys-timeli-fix-sqlalc-fukt29 December 14, 2021 13:47 Inactive
@IanMayo IanMayo temporarily deployed to pepys-timeli-fix-sqlalc-fukt29 December 14, 2021 14:03 Inactive
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #1114 (5e16209) into develop (f006e5e) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1114      +/-   ##
===========================================
+ Coverage    80.06%   80.07%   +0.01%     
===========================================
  Files          110      110              
  Lines        11896    11896              
===========================================
+ Hits          9524     9526       +2     
+ Misses        2372     2370       -2     
Impacted Files Coverage Δ
pepys_import/resolvers/command_line_resolver.py 94.85% <0.00%> (+0.25%) ⬆️
pepys_import/file/file_processor.py 98.73% <0.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b58dcf...5e16209. Read the comment docs.

@IanMayo IanMayo merged commit e25e594 into develop Dec 14, 2021
@IanMayo IanMayo deleted the fix-sqlalchemy-version branch December 14, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build issue on develop branch
2 participants