-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1089 full shore importer #1102
base: develop
Are you sure you want to change the base?
1089 full shore importer #1102
Conversation
…e data to confirm test failure resolution
Codecov Report
@@ Coverage Diff @@
## develop #1102 +/- ##
===========================================
+ Coverage 80.03% 80.33% +0.30%
===========================================
Files 110 111 +1
Lines 11889 12087 +198
===========================================
+ Hits 9515 9710 +195
- Misses 2374 2377 +3
Continue to review full report at Codecov.
|
importers/full_shore_importer.py
Outdated
state = datafile.create_state(data_store, self.platform, sensor, timestamp, self.short_name) | ||
|
||
location = Location(errors=self.errors, error_type=self.error_type) | ||
lat_degs = float(lat_token.text) * (180 / math.pi) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be neater to use Python's math.degrees()
function (as we do in the eag_importer
). This will make it easier to track instances where we're converting from radians to degrees.
This PR is left open as a draft PR pending answers about the units that the format uses. The code as written assumes some units:
These will need confirming before this gets merged. |
🧰 Issue
Fixes #1089
🚀 Overview:
Created an importer for the CSV output of the full shore / DNA format
🤔 Reason:
To allow Full Shore / DNA data to be imported into Pepys
🔨Work carried out:
Confirmations
interactive_review
if reviewers will need to see UI\docs
folderalembic revision
transitions