Init schemas during module initialization #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hilleer
reviewed
Dec 7, 2023
Comment on lines
+19
to
+21
| var validateSchema = getValidateSchemaInstance(); | ||
| var filterSchema = getFilterSchemaInstance(); | ||
| var validateSchemaNoReadonly = getValidateSchemaNoReadonlyInstance(); |
There was a problem hiding this comment.
Should we replace all this with const finally? 🙂
There was a problem hiding this comment.
Might be a good opportunity to give the library a slight overhaul and update.
There was a problem hiding this comment.
I almost did it here 😄 But I will make a new refactoring PR
JonathanMH
approved these changes
Dec 7, 2023
hilleer
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delayed schema initialization negatively impacts processing time of the first requests that use schema validation.
This PR initializes the schemas during module initialization - this will increase the startup time of application requiring this module, but this is preferred behaviour instead of increased response time of the first requests.