Added special hotkey config rules for comma and semicolon #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DLDante
reviewed
Dec 28, 2020
| // a printable 7 bit character? | ||
| if (key < 0x80 && key != Qt::Key_Space) | ||
| if (key < 0x80) |
There was a problem hiding this comment.
hi, pr description has no explanation on this line change, please could you add it?
There was a problem hiding this comment.
I edited the pr description to include the explanation
DLDante
approved these changes
Dec 29, 2020
This was referenced Jan 7, 2021
p12tic
approved these changes
Jan 10, 2021
|
We now have tests, so it's possible to easily see what this PR fixes and add regression tests if the PR breaks something. We can finally merge this improvement. Thanks a lot! |
p12tic
added a commit
to p12tic/barrier
that referenced
this pull request
Jan 10, 2021
This was referenced Jan 10, 2021
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config parser interprets commas and semicolons as syntax. This PR adds commas and semicolons to the special keys list so that ',' becomes "Comma" and ';' becomes "Semicolon". This allows hotkeys to contain commas and semicolons.
Fixes issue #778
Edited for additional comments on changes on line 215:
I had to reorder how
KeySequence::keyToString()decides how to serialize a key so that it will prioritize checking the special keys list before checking for 7-bit printable characters. This made excluding a space character (key != Qt::Key_Space) from the 7-bit printable character check (if (key < 0x80 && key != Qt::Key_Space)) redundant becauseQt::Key_Spaceis already in the special keys list and will already be substituted for"Space".