Fix build on Windows #732
Merged
Fix build on Windows #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shymega
added
build-infra
p12tic
approved these changes
Jun 4, 2020
|
@GeorgH93 Thanks! I assumed that we're building correctly on Azure Pipelines and that my errors would be caught :) |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple of issues that prevented the project from being built on Windows.
I have also modified the clean_build.bat file to retain the ERRORLEVEL so that the azure pipeline should actually fail if the build fails (currently the build script always exits with status code 0 which I assume is the reason that the azure build succeeds even thou the build itself failed).