Make connection message a NOTE for consistency #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When disconnected a NOTE log entry is made in the log, when connected it just prints which seems inconsistent to me: ``` [2020-06-01T11:50:55] INFO: AES256-GCM-SHA384 TLSv1.2 Kx=RSA Au=RSA Enc=AESGCM(256) Mac=AEAD /home/jonathan/barrier/src/lib/net/SecureSocket.cpp,872 connected to server [2020-06-01T11:52:43] INFO: entering screen ``` vs. ``` [2020-06-01T11:59:01] NOTE: disconnected from server /home/jonathan/barrier/src/lib/barrier/ClientApp.cpp,315 ``` Since everything else logs with a timestamp I suggest changing this to NOTE as well for connection events being logged.
p12tic
approved these changes
Jun 1, 2020
|
@p12tic @shymega @jmartens I think this might reintroduce the bugs in the GUI fixed by #664. I probably should have put a comment in the code there explaining why Until the GUI uses the IPC to communicate status with the server or client I think this might need to stay as a print. |
|
Indeed, we need a comment there explaining that this log message is much more important than it seems :-) |
|
@p12tic I'll put in a pull request when I get home and put a comment in there explaining the deviation from normal logging. |
Merged
This was referenced Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When disconnected a NOTE log entry is made in the log, when connected it just prints which seems inconsistent to me:
vs.
Since everything else logs with a timestamp I suggest changing this to NOTE as well for connection events being logged.