Only require Qt5 when building the GUI #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 6c88843 made Qt5 mandatory for all builds when it is only required for the GUI. There's already a find_package call in src/gui, it just needed the REQUIRED flag to be added.
|
Thanks, I totally forgot that would happen with all builds. Thanks for spotting it! I'll merge this in now. |
shymega
added
build-infra
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 6c88843 made Qt5 mandatory for all builds when it is only required for the GUI. There's already a
find_packagecall in src/gui, it just needed theREQUIREDflag to be added.