Use -pthread flag and simplify pthread build logic #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes -lpthread is not enough. This has caused build failures on Gentoo Linux in the past. The logic also seems needlessly complex. We check for HAVE_PTHREAD on UNIX platforms even though CMake errors out if pthreads are not found. Similarly, we have a fallback for HAVE_PTHREAD_SIGNAL being false even though we always set it to true.
p12tic
approved these changes
Mar 10, 2020
|
Ping? |
|
Apologies for the late reply. I'm just taking a look now, then I'll review and make a decision whenever to merge. Thanks! |
|
Looking good. I will merge now. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes
-lpthreadis not enough. This has caused build failures on Gentoo Linux in the past.The logic also seems needlessly complex. We check for
HAVE_PTHREADon UNIX platforms even though CMake errors out if pthreads are not found. Similarly, we have a fallback forHAVE_PTHREAD_SIGNALbeing false even though we always set it to true.