Skip to content

Commit

Permalink
Remove unused IEventQueue::isEmpty() method to simplify code understa…
Browse files Browse the repository at this point in the history
…nding

Current code base don't use IEventQueue::isEmpty() method.
Remove it to simplify IEventQueue API and to remove confusion with
IEventQueueBuffer with same name.

The IEventQueueBuffer::isEmpty() and all its implementations kept unchanged
  • Loading branch information
Vasily Galkin committed May 12, 2020
1 parent dbd1082 commit 8ab6ad6
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 14 deletions.
6 changes: 0 additions & 6 deletions src/lib/base/EventQueue.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -436,12 +436,6 @@ EventQueue::removeHandlers(void* target)
}
}

bool
EventQueue::isEmpty() const
{
return (m_buffer->isEmpty() && getNextTimerTimeout() != 0.0);
}

IEventJob*
EventQueue::getHandler(Event::Type type, void* target) const
{
Expand Down
1 change: 0 additions & 1 deletion src/lib/base/EventQueue.h
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ class EventQueue : public IEventQueue {
virtual void removeHandlers(void* target);
virtual Event::Type
registerTypeOnce(Event::Type& type, const char* name);
virtual bool isEmpty() const;
virtual IEventJob* getHandler(Event::Type type, void* target) const;
virtual const char* getTypeName(Event::Type type);
virtual Event::Type
Expand Down
7 changes: 0 additions & 7 deletions src/lib/base/IEventQueue.h
Original file line number Diff line number Diff line change
Expand Up @@ -189,13 +189,6 @@ class IEventQueue : public IInterface {
//! @name accessors
//@{

//! Test if queue is empty
/*!
Returns true iff the queue has no events in it, including timer
events.
*/
virtual bool isEmpty() const = 0;

//! Get an event handler
/*!
Finds and returns the event handler for the \p type, \p target pair
Expand Down

0 comments on commit 8ab6ad6

Please sign in to comment.